Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CheckClusterIngressHealthy to the pr_test.go #869

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dishankkalra23
Copy link

Description

This PR exposes CheckClusterIngressHealthy to the pr_test.go to know the ingress state of the cluster.

https://github.ibm.com/GoldenEye/issues/issues/10545

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Addition of getClusterIngress method to expose the ingress state of the cluster

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@dishankkalra23
Copy link
Author

/run pipeline

@dishankkalra23
Copy link
Author

TestRunRoksPattern is getting skipped and PostApplyHook doesn't initiate

@@ -221,6 +221,7 @@ func TestRunRoksPattern(t *testing.T) {
}
Copy link
Author

@dishankkalra23 dishankkalra23 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocofaigh @toddgiguere The PostApplyHook never executes because TestRunRoksPattern are skipped when enableSchematicsTests is True. Where should we add the hook because other test methods like TestRunVSIPattern, TestRunVpcPattern are also getting skipped.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The landing zone tests executes in schematics and post apply hook is yet to be supported in schematics.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking this to deep dive today to decide whether we add a support for post apply hook in schematics or is there any other way to approach it?

@dishankkalra23
Copy link
Author

dishankkalra23 commented Sep 24, 2024

Screenshot 2024-09-25 at 2 37 32 AM

I ran TestRunRoksPattern in local after commenting out enableSchematicsTests and I found that this example creates more than one cluster.

TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:   "cluster_names": {
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:     "sensitive": false,
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:     "type": [
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:       "tuple",
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:       [
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:         "string",
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:         "string"
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:       ]
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:     ],
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:     "value": [
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:       "ocp-ioblal-management-cluster",
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:       "ocp-ioblal-workload-cluster"
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:     ]
TestRunRoksPattern 2024-09-16T13:54:54+05:30 logger.go:66:   },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant